Rename methods that use TrainingSample to _old

This commit is contained in:
2021-04-11 21:00:04 -05:00
parent 5fd13981d4
commit 2da60dd293
13 changed files with 63 additions and 63 deletions

View File

@@ -25,7 +25,7 @@ class Component:
strategy.
"""
def before_solve_lp(
def before_solve_lp_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -62,7 +62,7 @@ class Component:
"""
return
def after_solve_lp(
def after_solve_lp_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -77,7 +77,7 @@ class Component:
"""
return
def before_solve_mip(
def before_solve_mip_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -92,7 +92,7 @@ class Component:
"""
return
def after_solve_mip(
def after_solve_mip_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -107,7 +107,7 @@ class Component:
"""
return
def sample_xy(
def sample_xy_old(
self,
instance: Instance,
sample: TrainingSample,
@@ -128,7 +128,7 @@ class Component:
for instance in instances:
instance.load()
for sample in instance.training_data:
xy = self.sample_xy(instance, sample)
xy = self.sample_xy_old(instance, sample)
if xy is None:
continue
x_sample, y_sample = xy
@@ -213,11 +213,11 @@ class Component:
for instance in instances:
instance.load()
for sample in instance.training_data:
ev += [self.sample_evaluate(instance, sample)]
ev += [self.sample_evaluate_old(instance, sample)]
instance.free()
return ev
def sample_evaluate(
def sample_evaluate_old(
self,
instance: Instance,
sample: TrainingSample,

View File

@@ -79,7 +79,7 @@ class DynamicConstraintsComponent(Component):
return x, y, cids
@overrides
def sample_xy(
def sample_xy_old(
self,
instance: "Instance",
sample: TrainingSample,
@@ -139,7 +139,7 @@ class DynamicConstraintsComponent(Component):
self.thresholds[category].fit(self.classifiers[category], npx, npy)
@overrides
def sample_evaluate(
def sample_evaluate_old(
self,
instance: "Instance",
sample: TrainingSample,

View File

@@ -54,7 +54,7 @@ class DynamicLazyConstraintsComponent(Component):
instance.enforce_lazy_constraint(solver.internal_solver, model, cid)
@overrides
def before_solve_mip(
def before_solve_mip_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -93,12 +93,12 @@ class DynamicLazyConstraintsComponent(Component):
# Delegate ML methods to self.dynamic
# -------------------------------------------------------------------
@overrides
def sample_xy(
def sample_xy_old(
self,
instance: "Instance",
sample: TrainingSample,
) -> Tuple[Dict, Dict]:
return self.dynamic.sample_xy(instance, sample)
return self.dynamic.sample_xy_old(instance, sample)
def sample_predict(
self,
@@ -120,9 +120,9 @@ class DynamicLazyConstraintsComponent(Component):
self.dynamic.fit_xy(x, y)
@overrides
def sample_evaluate(
def sample_evaluate_old(
self,
instance: "Instance",
sample: TrainingSample,
) -> Dict[Hashable, Dict[str, float]]:
return self.dynamic.sample_evaluate(instance, sample)
return self.dynamic.sample_evaluate_old(instance, sample)

View File

@@ -37,7 +37,7 @@ class UserCutsComponent(Component):
self.n_added_in_callback = 0
@overrides
def before_solve_mip(
def before_solve_mip_old(
self,
solver: "LearningSolver",
instance: "Instance",
@@ -79,7 +79,7 @@ class UserCutsComponent(Component):
logger.debug(f"Added {len(cids)} violated user cuts")
@overrides
def after_solve_mip(
def after_solve_mip_old(
self,
solver: "LearningSolver",
instance: "Instance",
@@ -96,12 +96,12 @@ class UserCutsComponent(Component):
# Delegate ML methods to self.dynamic
# -------------------------------------------------------------------
@overrides
def sample_xy(
def sample_xy_old(
self,
instance: "Instance",
sample: TrainingSample,
) -> Tuple[Dict, Dict]:
return self.dynamic.sample_xy(instance, sample)
return self.dynamic.sample_xy_old(instance, sample)
def sample_predict(
self,
@@ -123,9 +123,9 @@ class UserCutsComponent(Component):
self.dynamic.fit_xy(x, y)
@overrides
def sample_evaluate(
def sample_evaluate_old(
self,
instance: "Instance",
sample: TrainingSample,
) -> Dict[Hashable, Dict[str, float]]:
return self.dynamic.sample_evaluate(instance, sample)
return self.dynamic.sample_evaluate_old(instance, sample)

View File

@@ -36,7 +36,7 @@ class ObjectiveValueComponent(Component):
self.regressor_prototype = regressor
@overrides
def before_solve_mip(
def before_solve_mip_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -68,7 +68,7 @@ class ObjectiveValueComponent(Component):
sample: TrainingSample,
) -> Dict[str, float]:
pred: Dict[str, float] = {}
x, _ = self.sample_xy(instance, sample)
x, _ = self.sample_xy_old(instance, sample)
for c in ["Upper bound", "Lower bound"]:
if c in self.regressors is not None:
pred[c] = self.regressors[c].predict(np.array(x[c]))[0, 0]
@@ -77,7 +77,7 @@ class ObjectiveValueComponent(Component):
return pred
@overrides
def sample_xy(
def sample_xy_old(
self,
instance: Instance,
sample: TrainingSample,
@@ -99,7 +99,7 @@ class ObjectiveValueComponent(Component):
return x, y
@overrides
def sample_evaluate(
def sample_evaluate_old(
self,
instance: Instance,
sample: TrainingSample,

View File

@@ -60,7 +60,7 @@ class PrimalSolutionComponent(Component):
self.classifier_prototype = classifier
@overrides
def before_solve_mip(
def before_solve_mip_old(
self,
solver: "LearningSolver",
instance: Instance,
@@ -110,7 +110,7 @@ class PrimalSolutionComponent(Component):
assert instance.features.variables is not None
# Compute y_pred
x, _ = self.sample_xy(instance, sample)
x, _ = self.sample_xy_old(instance, sample)
y_pred = {}
for category in x.keys():
assert category in self.classifiers, (
@@ -144,7 +144,7 @@ class PrimalSolutionComponent(Component):
return solution
@overrides
def sample_xy(
def sample_xy_old(
self,
instance: Instance,
sample: TrainingSample,
@@ -180,7 +180,7 @@ class PrimalSolutionComponent(Component):
return x, y
@overrides
def sample_evaluate(
def sample_evaluate_old(
self,
instance: Instance,
sample: TrainingSample,

View File

@@ -51,7 +51,7 @@ class StaticLazyConstraintsComponent(Component):
self.n_iterations: int = 0
@overrides
def before_solve_mip(
def before_solve_mip_old(
self,
solver: "LearningSolver",
instance: "Instance",
@@ -85,7 +85,7 @@ class StaticLazyConstraintsComponent(Component):
self.n_iterations = 0
@overrides
def after_solve_mip(
def after_solve_mip_old(
self,
solver: "LearningSolver",
instance: "Instance",
@@ -151,7 +151,7 @@ class StaticLazyConstraintsComponent(Component):
) -> List[Hashable]:
assert instance.features.constraints is not None
x, y = self.sample_xy(instance, sample)
x, y = self.sample_xy_old(instance, sample)
category_to_cids: Dict[Hashable, List[Hashable]] = {}
for (cid, cfeatures) in instance.features.constraints.items():
if cfeatures.category is None:
@@ -174,7 +174,7 @@ class StaticLazyConstraintsComponent(Component):
return enforced_cids
@overrides
def sample_xy(
def sample_xy_old(
self,
instance: "Instance",
sample: TrainingSample,

View File

@@ -162,7 +162,7 @@ class LearningSolver:
instance.features.__dict__ = features.__dict__
sample.after_load = features
callback_args = (
callback_args_old = (
self,
instance,
model,
@@ -177,7 +177,7 @@ class LearningSolver:
if self.solve_lp:
logger.debug("Running before_solve_lp callbacks...")
for component in self.components.values():
component.before_solve_lp(*callback_args)
component.before_solve_lp_old(*callback_args_old)
logger.info("Solving root LP relaxation...")
lp_stats = self.internal_solver.solve_lp(tee=tee)
@@ -188,7 +188,7 @@ class LearningSolver:
logger.debug("Running after_solve_lp callbacks...")
for component in self.components.values():
component.after_solve_lp(*callback_args)
component.after_solve_lp_old(*callback_args_old)
# Extract features (after-lp)
# -------------------------------------------------------
@@ -232,7 +232,7 @@ class LearningSolver:
# -------------------------------------------------------
logger.debug("Running before_solve_mip callbacks...")
for component in self.components.values():
component.before_solve_mip(*callback_args)
component.before_solve_mip_old(*callback_args_old)
# Solve MIP
# -------------------------------------------------------
@@ -269,7 +269,7 @@ class LearningSolver:
# -------------------------------------------------------
logger.debug("Calling after_solve_mip callbacks...")
for component in self.components.values():
component.after_solve_mip(*callback_args)
component.after_solve_mip_old(*callback_args_old)
# Flush
# -------------------------------------------------------