Replace push_sample by create_sample

miplearn/instance/base.py

@@ -6,7 +6,7 @@ import logging
 from abc import ABC, abstractmethod
 from typing import Any, List, TYPE_CHECKING, Dict
 
-from miplearn.features.sample import Sample
+from miplearn.features.sample import Sample, MemorySample
 
 logger = logging.getLogger(__name__)
 
@@ -192,5 +192,7 @@ class Instance(ABC):
     def get_samples(self) -> List[Sample]:
         return self._samples
 
-    def push_sample(self, sample: Sample) -> None:
+    def create_sample(self) -> Sample:
+        sample = MemorySample()
         self._samples.append(sample)
+        return sample

miplearn/instance/picklegz.py

@@ -137,9 +137,9 @@ class PickleGzInstance(Instance):
         return self.instance.get_samples()
 
     @overrides
-    def push_sample(self, sample: Sample) -> None:
+    def create_sample(self) -> Sample:
         assert self.instance is not None
-        self.instance.push_sample(sample)
+        return self.instance.create_sample()
 
 
 def write_pickle_gz(obj: Any, filename: str) -> None:

miplearn/solvers/learning.py

@@ -150,8 +150,7 @@ class LearningSolver:
 
         # Initialize training sample
         # -------------------------------------------------------
-        sample = MemorySample()
+        sample = instance.create_sample()
-        instance.push_sample(sample)
 
         # Initialize stats
         # -------------------------------------------------------