ANL-CEEESA/MIPLearn
1
0
Fork 0
mirror of https://github.com/ANL-CEEESA/MIPLearn.git synced 2025-12-06 09:28:51 -06:00
Code Issues Packages Projects Releases Wiki Activity

Do nothing on put_scalar(None)

Browse Source
This commit is contained in:
Alinson S. Xavier
2021-07-27 10:55:19 -05:00
parent 6c98986675
commit f1dc450cbf
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
miplearn/features/sample.py
View File

@@ -132,6 +132,8 @@ class MemorySample(Sample):
@overrides @overrides
def put_scalar(self, key: str, value: Scalar) -> None: def put_scalar(self, key: str, value: Scalar) -> None:
if value is None:
return
self._assert_is_scalar(value) self._assert_is_scalar(value)
self._put(key, value) self._put(key, value)
@@ -220,6 +222,8 @@ class Hdf5Sample(Sample):
@overrides @overrides
def put_scalar(self, key: str, value: Any) -> None: def put_scalar(self, key: str, value: Any) -> None:
if value is None:
return
self._assert_is_scalar(value) self._assert_is_scalar(value)
self._put(key, value) self._put(key, value)

5
tests/features/test_sample.py
View File

@@ -39,11 +39,16 @@ def _test_sample(sample: Sample) -> None:
# Bytes # Bytes
_assert_roundtrip_bytes(sample, b"\x00\x01\x02\x03\x04\x05") _assert_roundtrip_bytes(sample, b"\x00\x01\x02\x03\x04\x05")
# Querying unknown keys should return None
assert sample.get_scalar("unknown-key") is None assert sample.get_scalar("unknown-key") is None
assert sample.get_vector("unknown-key") is None assert sample.get_vector("unknown-key") is None
assert sample.get_vector_list("unknown-key") is None assert sample.get_vector_list("unknown-key") is None
assert sample.get_bytes("unknown-key") is None assert sample.get_bytes("unknown-key") is None
# Putting None should not modify HDF5 file
sample.put_scalar("key", None)
sample.put_vector("key", None)
def _assert_roundtrip_bytes(sample: Sample, expected: Any) -> None: def _assert_roundtrip_bytes(sample: Sample, expected: Any) -> None:
sample.put_bytes("key", expected) sample.put_bytes("key", expected)