From 0d1d8a9eeb9acfed3ca4b572172e0020d3611a84 Mon Sep 17 00:00:00 2001
From: Felix Wiemuth <533601+felixwiemuth@users.noreply.github.com>
Date: Fri, 16 Sep 2022 14:23:14 +0200
Subject: [PATCH] Remove redundant rescheduling after reboot

The action is already performed via HabitsApplication.onCreate.
It is sufficient that there is a boot receiver.
---
 .../java/org/isoron/uhabits/receivers/ReminderController.kt   | 4 ----
 .../java/org/isoron/uhabits/receivers/ReminderReceiver.kt     | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderController.kt b/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderController.kt
index 38ba3a1b4..718e7f535 100644
--- a/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderController.kt
+++ b/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderController.kt
@@ -37,10 +37,6 @@ class ReminderController @Inject constructor(
     private val notificationTray: NotificationTray,
     private val preferences: Preferences
 ) {
-    fun onBootCompleted() {
-        reminderScheduler.scheduleAll()
-    }
-
     fun onShowReminder(
         habit: Habit,
         timestamp: Timestamp,
diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderReceiver.kt b/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderReceiver.kt
index 6eb10dc7e..a08e817e6 100644
--- a/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderReceiver.kt
+++ b/uhabits-android/src/main/java/org/isoron/uhabits/receivers/ReminderReceiver.kt
@@ -96,7 +96,7 @@ class ReminderReceiver : BroadcastReceiver() {
                 }
                 Intent.ACTION_BOOT_COMPLETED -> {
                     Log.d("ReminderReceiver", "onBootCompleted")
-                    reminderController.onBootCompleted()
+                    // NOTE: Some activity is executed after boot through HabitsApplication, so receiving ACTION_BOOT_COMPLETED is essential.
                 }
             }
         } catch (e: RuntimeException) {