From 2d943b5942e20483a80d597736e92652cc37a896 Mon Sep 17 00:00:00 2001 From: Quentin Hibon Date: Wed, 27 Jan 2021 12:09:23 +0100 Subject: [PATCH] Fix signature of onSharedPreferenceChanged The 'key' argument is null when called from android.app.SharedPreferencesImpl. --- .../org/isoron/uhabits/activities/settings/SettingsFragment.kt | 2 +- .../org/isoron/uhabits/preferences/SharedPreferencesStorage.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/settings/SettingsFragment.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/settings/SettingsFragment.kt index 4187f5008..042ec2777 100644 --- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/settings/SettingsFragment.kt +++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/settings/SettingsFragment.kt @@ -147,7 +147,7 @@ class SettingsFragment : PreferenceFragmentCompat(), OnSharedPreferenceChangeLis override fun onSharedPreferenceChanged( sharedPreferences: SharedPreferences, - key: String + key: String? ) { if (key == "pref_widget_opacity" && widgetUpdater != null) { Log.d("SettingsFragment", "updating widgets") diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/preferences/SharedPreferencesStorage.kt b/uhabits-android/src/main/java/org/isoron/uhabits/preferences/SharedPreferencesStorage.kt index 279357858..febc7f976 100644 --- a/uhabits-android/src/main/java/org/isoron/uhabits/preferences/SharedPreferencesStorage.kt +++ b/uhabits-android/src/main/java/org/isoron/uhabits/preferences/SharedPreferencesStorage.kt @@ -79,7 +79,7 @@ class SharedPreferencesStorage override fun onSharedPreferenceChanged( sharedPreferences: SharedPreferences, - key: String + key: String? ) { val preferences = this.preferences ?: return sharedPreferences.unregisterOnSharedPreferenceChangeListener(this)