isoron/loop
1
1
Fork 0
mirror of https://github.com/iSoron/uhabits.git synced 2025-12-06 01:08:50 -06:00
Code Issues Packages Projects Releases Wiki Activity

Add reordering tests for SQLiteHabitList

Browse Source
This commit is contained in:
Alinson S. Xavier
2017-06-23 09:29:19 -04:00
parent 5d9563b9d8
commit 33f7acc9ca
2 changed files with 46 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
uhabits-core/src/main/java/org/isoron/uhabits/core/models/sqlite/SQLiteHabitList.java
View File

@@ -201,24 +201,21 @@ public class SQLiteHabitList extends HabitList
if (toRecord == null) if (toRecord == null)
throw new RuntimeException("habit not in database"); throw new RuntimeException("habit not in database");
Integer fromPos = fromRecord.position; if (toRecord.position < fromRecord.position)
Integer toPos = toRecord.position;
if (toPos < fromPos)
{ {
repository.execSQL("update habits set position = position + 1 " + repository.execSQL("update habits set position = position + 1 " +
"where position >= ? and position < ?", "where position >= ? and position < ?",
toPos, fromPos); toRecord.position, fromRecord.position);
} }
else else
{ {
repository.execSQL("update habits set position = position - 1 " + repository.execSQL("update habits set position = position - 1 " +
"where position > ? and position <= ?", "where position > ? and position <= ?",
fromPos, toPos); fromRecord.position, toRecord.position);
} }
fromRecord.position = toPos; fromRecord.position = toRecord.position;
repository.save(fromRecord); repository.save(fromRecord);
update(from);
getObservable().notifyListeners(); getObservable().notifyListeners();
} }

48
uhabits-core/src/test/java/org/isoron/uhabits/core/models/sqlite/SQLiteHabitListTest.java
View File

@@ -28,12 +28,10 @@ import org.isoron.uhabits.core.models.sqlite.records.*;
import org.junit.*; import org.junit.*;
import org.junit.rules.*; import org.junit.rules.*;
import static org.hamcrest.MatcherAssert.*; import static org.hamcrest.CoreMatchers.*;
import static org.hamcrest.core.IsEqual.*; import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.Assert.assertNotNull; import static org.junit.Assert.*;
import static org.junit.Assert.assertNull; import static org.mockito.Mockito.*;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
public class SQLiteHabitListTest extends BaseUnitTest public class SQLiteHabitListTest extends BaseUnitTest
{ {
@@ -183,4 +181,42 @@ public class SQLiteHabitListTest extends BaseUnitTest
assertNotNull(rec); assertNotNull(rec);
assertThat(rec.position, equalTo(2)); assertThat(rec.position, equalTo(2));
} }
@Test
public void testReorder()
{
// Same as HabitListTest#testReorder
int operations[][] = {
{ 5, 2 }, { 3, 7 }, { 4, 4 }, { 3, 2 }
};
int expectedPosition[][] = {
{ 0, 1, 3, 4, 5, 2, 6, 7, 8, 9 },
{ 0, 1, 7, 3, 4, 2, 5, 6, 8, 9 },
{ 0, 1, 7, 3, 4, 2, 5, 6, 8, 9 },
{ 0, 1, 7, 2, 4, 3, 5, 6, 8, 9 },
};
for (int i = 0; i < operations.length; i++)
{
int from = operations[i][0];
int to = operations[i][1];
Habit fromHabit = habitList.getByPosition(from);
Habit toHabit = habitList.getByPosition(to);
habitList.reorder(fromHabit, toHabit);
habitList.reload();
int actualPositions[] = new int[10];
for (int j = 0; j < 10; j++)
{
Habit h = habitList.getById(j);
assertNotNull(h);
actualPositions[j] = habitList.indexOf(h);
}
assertThat(actualPositions, equalTo(expectedPosition[i]));
}
}
} }