From 3e6a9181d6d836a85984bf166a57e676438ef3f0 Mon Sep 17 00:00:00 2001 From: sgallese Date: Tue, 21 Sep 2021 19:16:00 -0700 Subject: [PATCH] Code review- keep timer offset to one second --- .../java/org/isoron/uhabits/core/utils/DateUtils.kt | 7 ++++++- .../java/org/isoron/uhabits/core/utils/MidnightTimer.kt | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/DateUtils.kt b/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/DateUtils.kt index fd7929b87..8af545504 100644 --- a/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/DateUtils.kt +++ b/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/DateUtils.kt @@ -36,10 +36,15 @@ abstract class DateUtils { private var startDayHourOffset: Int = 0 private var startDayMinuteOffset: Int = 0 + /** + * Number of milliseconds in one second. + */ + const val SECOND_LENGTH: Long = 1000 + /** * Number of milliseconds in one minute. */ - const val MINUTE_LENGTH: Long = 60 * 1000 + const val MINUTE_LENGTH: Long = 60 * SECOND_LENGTH /** * Number of milliseconds in one hour. diff --git a/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/MidnightTimer.kt b/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/MidnightTimer.kt index 3dbba72c5..5ae0b6ad7 100644 --- a/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/MidnightTimer.kt +++ b/uhabits-core/src/jvmMain/java/org/isoron/uhabits/core/utils/MidnightTimer.kt @@ -39,7 +39,7 @@ open class MidnightTimer @Inject constructor() { @Synchronized fun onPause(): MutableList? = executor.shutdownNow() - @Synchronized fun onResume(delayOffsetInMillis: Long = DateUtils.MINUTE_LENGTH, testExecutor: ScheduledExecutorService? = null) { + @Synchronized fun onResume(delayOffsetInMillis: Long = DateUtils.SECOND_LENGTH, testExecutor: ScheduledExecutorService? = null) { executor = testExecutor ?: Executors.newSingleThreadScheduledExecutor() executor.scheduleAtFixedRate( { notifyListeners() },