isoron/loop
1
1
Fork 0
mirror of https://github.com/iSoron/uhabits.git synced 2025-12-06 17:18:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

HabitCardListAdapter: Return copy of list of selected items

Browse Source 
Previously, HabitCardListAdapter returned a pointer to the list, instead of a
copy. By the time other parts of the application were reading the list, its
contents had already changed. This prevented the user from deleting or
archiving habits.
This commit is contained in:
Alinson S. Xavier
2021-01-30 10:26:07 -06:00
parent 89bde4c9ae
commit 48c1adb3bb
3 changed files with 28 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
uhabits-core/src/jvmTest/java/org/isoron/uhabits/core/ui/screens/habits/list/ListHabitsSelectionMenuBehaviorTest.kt
View File

@@ -52,27 +52,27 @@ class ListHabitsSelectionMenuBehaviorTest : BaseUnitTest() {
@Test
@Throws(Exception::class)
fun canArchive() {
whenever(adapter.selected).thenReturn(listOf(habit1, habit2))
whenever(adapter.getSelected()).thenReturn(listOf(habit1, habit2))
assertFalse(behavior.canArchive())
whenever(adapter.selected).thenReturn(listOf(habit2, habit3))
whenever(adapter.getSelected()).thenReturn(listOf(habit2, habit3))
assertTrue(behavior.canArchive())
}
@Test
@Throws(Exception::class)
fun canEdit() {
whenever(adapter.selected).thenReturn(listOf(habit1))
whenever(adapter.getSelected()).thenReturn(listOf(habit1))
assertTrue(behavior.canEdit())
whenever(adapter.selected).thenReturn(listOf(habit1, habit2))
whenever(adapter.getSelected()).thenReturn(listOf(habit1, habit2))
assertFalse(behavior.canEdit())
}
@Test
@Throws(Exception::class)
fun canUnarchive() {
whenever(adapter.selected).thenReturn(listOf(habit1, habit2))
whenever(adapter.getSelected()).thenReturn(listOf(habit1, habit2))
assertFalse(behavior.canUnarchive())
whenever(adapter.selected).thenReturn(listOf(habit1))
whenever(adapter.getSelected()).thenReturn(listOf(habit1))
assertTrue(behavior.canUnarchive())
}
@@ -80,7 +80,7 @@ class ListHabitsSelectionMenuBehaviorTest : BaseUnitTest() {
@Throws(Exception::class)
fun onArchiveHabits() {
assertFalse(habit2.isArchived)
whenever(adapter.selected).thenReturn(listOf(habit2))
whenever(adapter.getSelected()).thenReturn(listOf(habit2))
behavior.onArchiveHabits()
assertTrue(habit2.isArchived)
}
@@ -90,7 +90,7 @@ class ListHabitsSelectionMenuBehaviorTest : BaseUnitTest() {
fun onChangeColor() {
assertThat(habit1.color, equalTo(PaletteColor(8)))
assertThat(habit2.color, equalTo(PaletteColor(8)))
whenever(adapter.selected).thenReturn(listOf(habit1, habit2))
whenever(adapter.getSelected()).thenReturn(listOf(habit1, habit2))
behavior.onChangeColor()
verify(screen)
.showColorPicker(eq(PaletteColor(8)), colorPickerCallback.capture())
@@ -103,7 +103,7 @@ class ListHabitsSelectionMenuBehaviorTest : BaseUnitTest() {
fun onDeleteHabits() {
val id = habit1.id!!
habitList.getById(id)!!
whenever(adapter.selected).thenReturn(listOf(habit1))
whenever(adapter.getSelected()).thenReturn(listOf(habit1))
behavior.onDeleteHabits()
verify(screen).showDeleteConfirmationScreen(deleteCallback.capture(), eq(1))
deleteCallback.lastValue.onConfirmed()
@@ -114,7 +114,7 @@ class ListHabitsSelectionMenuBehaviorTest : BaseUnitTest() {
@Throws(Exception::class)
fun onEditHabits() {
val selected: List<Habit> = listOf(habit1, habit2)
whenever(adapter.selected).thenReturn(selected)
whenever(adapter.getSelected()).thenReturn(selected)
behavior.onEditHabits()
verify(screen).showEditHabitsScreen(selected)
}
@@ -123,7 +123,7 @@ class ListHabitsSelectionMenuBehaviorTest : BaseUnitTest() {
@Throws(Exception::class)
fun onUnarchiveHabits() {
assertTrue(habit1.isArchived)
whenever(adapter.selected).thenReturn(listOf(habit1))
whenever(adapter.getSelected()).thenReturn(listOf(habit1))
behavior.onUnarchiveHabits()
assertFalse(habit1.isArchived)
}