From 65af1cc99b2c70f2fdd8405dedf930b36e41c371 Mon Sep 17 00:00:00 2001 From: veyndan Date: Sat, 21 Sep 2019 02:56:13 +0100 Subject: [PATCH] Refactor getColor(Context, Int) --- .../java/org/isoron/uhabits/utils/PaletteUtils.kt | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/android/uhabits-android/src/main/java/org/isoron/uhabits/utils/PaletteUtils.kt b/android/uhabits-android/src/main/java/org/isoron/uhabits/utils/PaletteUtils.kt index dda87dd28..897129f64 100644 --- a/android/uhabits-android/src/main/java/org/isoron/uhabits/utils/PaletteUtils.kt +++ b/android/uhabits-android/src/main/java/org/isoron/uhabits/utils/PaletteUtils.kt @@ -43,15 +43,12 @@ object PaletteUtils { @JvmStatic fun getColor(context: Context, paletteColor: Int): Int { - var paletteColor = paletteColor - - val res = StyledResources(context) - val palette = res.palette - if (paletteColor < 0 || paletteColor >= palette.size) { + val palette = StyledResources(context).palette + return if (paletteColor in palette.indices) { + palette[paletteColor] + } else { Log.w("ColorHelper", "Invalid color: $paletteColor. Returning default.") - paletteColor = 0 + palette[0] } - - return palette[paletteColor] } }