From 7b68938e14ed3712218aa0302a68d83d3ff53316 Mon Sep 17 00:00:00 2001
From: "Alinson S. Xavier" <git@axavier.org>
Date: Sat, 13 Mar 2021 18:45:18 -0600
Subject: [PATCH] ButtonView: Adjust size of question marks

---
 .../habits/list/views/CheckmarkButtonView.kt  |  7 ++++-
 .../habits/list/views/NumberButtonView.kt     | 26 ++++++++++++-------
 2 files changed, 22 insertions(+), 11 deletions(-)

diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt
index ad9b02826..77d6dd77e 100644
--- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt
+++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt
@@ -124,7 +124,6 @@ class CheckmarkButtonView(
             typeface = getFontAwesome()
             isAntiAlias = true
             textAlign = Paint.Align.CENTER
-            textSize = dim(R.dimen.smallTextSize)
         }
 
         fun draw(canvas: Canvas) {
@@ -147,6 +146,12 @@ class CheckmarkButtonView(
                 }
                 else -> R.string.fa_check
             }
+
+            paint.textSize = when (value) {
+                UNKNOWN -> dim(R.dimen.smallerTextSize)
+                else -> dim(R.dimen.smallTextSize)
+            }
+
             val label = resources.getString(id)
             val em = paint.measureText("m")
 
diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/NumberButtonView.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/NumberButtonView.kt
index 353094c26..b7517b97b 100644
--- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/NumberButtonView.kt
+++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/NumberButtonView.kt
@@ -33,6 +33,7 @@ import org.isoron.uhabits.core.preferences.Preferences
 import org.isoron.uhabits.inject.ActivityContext
 import org.isoron.uhabits.utils.InterfaceUtils.getDimension
 import org.isoron.uhabits.utils.StyledResources
+import org.isoron.uhabits.utils.dim
 import org.isoron.uhabits.utils.getFontAwesome
 import org.isoron.uhabits.utils.showMessage
 import java.text.DecimalFormat
@@ -131,22 +132,22 @@ class NumberButtonView(
         private val lowContrast: Int
         private val mediumContrast: Int
 
-        private val pRegular: TextPaint = TextPaint().apply {
+        private val pUnit: TextPaint = TextPaint().apply {
             textSize = getDimension(context, R.dimen.smallerTextSize)
             typeface = NORMAL_TYPEFACE
             isAntiAlias = true
             textAlign = Paint.Align.CENTER
         }
 
-        private val pBold: TextPaint = TextPaint().apply {
-            textSize = getDimension(context, R.dimen.smallTextSize)
+        private val pNumber: TextPaint = TextPaint().apply {
+            textSize = dim(R.dimen.smallTextSize)
             typeface = BOLD_TYPEFACE
             isAntiAlias = true
             textAlign = Paint.Align.CENTER
         }
 
         init {
-            em = pBold.measureText("m")
+            em = pNumber.measureText("m")
             lowContrast = sr.getColor(R.attr.contrast40)
             mediumContrast = sr.getColor(R.attr.contrast60)
         }
@@ -160,31 +161,36 @@ class NumberButtonView(
 
             val label: String
             val typeface: Typeface
+            val textSize: Float
 
             when {
                 value >= 0 -> {
                     label = value.toShortString()
                     typeface = BOLD_TYPEFACE
+                    textSize = dim(R.dimen.smallTextSize)
                 }
                 preferences.areQuestionMarksEnabled() -> {
                     label = resources.getString(R.string.fa_question)
                     typeface = getFontAwesome()
+                    textSize = dim(R.dimen.smallerTextSize)
                 }
                 else -> {
                     label = "0"
                     typeface = BOLD_TYPEFACE
+                    textSize = dim(R.dimen.smallTextSize)
                 }
             }
 
-            pBold.color = activeColor
-            pBold.typeface = typeface
-            pRegular.color = activeColor
+            pNumber.textSize = textSize
+            pNumber.color = activeColor
+            pNumber.typeface = typeface
+            pUnit.color = activeColor
 
             rect.set(0f, 0f, width.toFloat(), height.toFloat())
-            canvas.drawText(label, rect.centerX(), rect.centerY(), pBold)
+            canvas.drawText(label, rect.centerX(), rect.centerY(), pNumber)
 
-            rect.offset(0f, 1.2f * em)
-            canvas.drawText(units, rect.centerX(), rect.centerY(), pRegular)
+            rect.offset(0f, 1.3f * em)
+            canvas.drawText(units, rect.centerX(), rect.centerY(), pUnit)
         }
     }
 }