diff --git a/app/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenu.java b/app/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenu.java index ebbd9d5d9..dc8fe057d 100644 --- a/app/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenu.java +++ b/app/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenu.java @@ -70,11 +70,11 @@ public class ListHabitsMenu extends BaseMenu MenuItem nightModeItem = menu.findItem(R.id.actionToggleNightMode); nightModeItem.setChecked(themeSwitcher.isNightMode()); - MenuItem showArchivedItem = menu.findItem(R.id.actionShowArchived); - showArchivedItem.setChecked(showArchived); + MenuItem hideArchivedItem = menu.findItem(R.id.actionHideArchived); + hideArchivedItem.setChecked(!showArchived); - MenuItem showCompletedItem = menu.findItem(R.id.actionShowCompleted); - showCompletedItem.setChecked(showCompleted); + MenuItem hideCompletedItem = menu.findItem(R.id.actionHideCompleted); + hideCompletedItem.setChecked(!showCompleted); } @Override @@ -102,12 +102,12 @@ public class ListHabitsMenu extends BaseMenu screen.showSettingsScreen(); return true; - case R.id.actionShowArchived: + case R.id.actionHideArchived: toggleShowArchived(); invalidate(); return true; - case R.id.actionShowCompleted: + case R.id.actionHideCompleted: toggleShowCompleted(); invalidate(); return true; diff --git a/app/src/main/res/menu/list_habits.xml b/app/src/main/res/menu/list_habits.xml index 0b0563cc2..4b3ab4fd0 100644 --- a/app/src/main/res/menu/list_habits.xml +++ b/app/src/main/res/menu/list_habits.xml @@ -35,16 +35,16 @@ app:showAsAction="ifRoom"> + android:title="@string/hide_archived"/> + android:title="@string/hide_completed"/> diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 465f4e396..82d37f949 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -94,7 +94,6 @@ Links Behavior Name - Show archived Settings Snooze interval @@ -182,5 +181,6 @@ Reminder sound None Filter - Show completed + Hide completed + Hide archived \ No newline at end of file diff --git a/app/src/test/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenuTest.java b/app/src/test/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenuTest.java index 4c7d09197..efe5fc517 100644 --- a/app/src/test/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenuTest.java +++ b/app/src/test/java/org/isoron/uhabits/activities/habits/list/ListHabitsMenuTest.java @@ -80,9 +80,9 @@ public class ListHabitsMenuTest extends BaseUnitTest Menu androidMenu = mock(Menu.class); when(androidMenu.findItem(R.id.actionToggleNightMode)).thenReturn( nightModeItem); - when(androidMenu.findItem(R.id.actionShowArchived)).thenReturn + when(androidMenu.findItem(R.id.actionHideArchived)).thenReturn (showArchivedItem); - when(androidMenu.findItem(R.id.actionShowCompleted)).thenReturn + when(androidMenu.findItem(R.id.actionHideCompleted)).thenReturn (showCompletedItem); menu.onCreate(androidMenu); @@ -134,14 +134,14 @@ public class ListHabitsMenuTest extends BaseUnitTest @Test public void testOnSelected_showArchived() { - onItemSelected(R.id.actionShowArchived); + onItemSelected(R.id.actionHideArchived); verify(preferences).setShowArchived(true); verify(adapter).setFilter(matcherCaptor.capture()); verify(adapter).refresh(); assertTrue(matcherCaptor.getValue().isArchivedAllowed()); reset(adapter); - onItemSelected(R.id.actionShowArchived); + onItemSelected(R.id.actionHideArchived); verify(preferences).setShowArchived(false); verify(adapter).setFilter(matcherCaptor.capture()); verify(adapter).refresh(); @@ -151,14 +151,14 @@ public class ListHabitsMenuTest extends BaseUnitTest @Test public void testOnSelected_showCompleted() { - onItemSelected(R.id.actionShowCompleted); + onItemSelected(R.id.actionHideCompleted); verify(preferences).setShowCompleted(true); verify(adapter).setFilter(matcherCaptor.capture()); verify(adapter).refresh(); assertTrue(matcherCaptor.getValue().isCompletedAllowed()); reset(adapter); - onItemSelected(R.id.actionShowCompleted); + onItemSelected(R.id.actionHideCompleted); verify(preferences).setShowCompleted(false); verify(adapter).setFilter(matcherCaptor.capture()); verify(adapter).refresh();