From ad8738180c6c116cf29a698925cd71e899e716d0 Mon Sep 17 00:00:00 2001 From: Gokul K Date: Tue, 4 Jul 2023 18:50:28 +0530 Subject: [PATCH] fixing some comments from @hiqua --- .../uhabits/activities/common/dialogs/NumberDialog.kt | 6 +++--- .../activities/habits/list/views/CheckmarkButtonView.kt | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt index 9adcfc0fd..1f344b173 100644 --- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt +++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt @@ -117,11 +117,11 @@ class NumberDialog : AppCompatDialogFragment() { val notes = view.notes.text.toString() onToggle(value, notes) requireDialog().dismiss() - val v = requireActivity().findViewById(R.id.konfettiLayout) + val konfettiView = requireActivity().findViewById(R.id.konfettiLayout) if (value > 0.0) { - showConfetti(v) - + //To motivate, show confetti even if some value is present + showConfetti(konfettiView) } } } diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt index a450a506e..e572bda07 100644 --- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt +++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt @@ -89,7 +89,7 @@ class CheckmarkButtonView( setOnLongClickListener(this) } - fun performToggle(v: View) { + fun performToggle(view: View) { value = Entry.nextToggleValue( value = value, isSkipEnabled = preferences.isSkipEnabled, @@ -98,7 +98,7 @@ class CheckmarkButtonView( onToggle(value, notes) performHapticFeedback(HapticFeedbackConstants.LONG_PRESS) when (value) { - YES_MANUAL -> showConfetti(v.rootView) + YES_MANUAL -> showConfetti(view.rootView) } invalidate() }