Fix reminder tests

pull/367/merge
Alinson S. Xavier 8 years ago
parent b46b7aae25
commit bf8c14fc03

@ -72,7 +72,7 @@ public class ReminderControllerTest extends BaseAndroidJVMTest
controller.onSnoozePressed(habit,null); controller.onSnoozePressed(habit,null);
verify(reminderScheduler).scheduleAtTime(habit, nowTz + 900000); verify(reminderScheduler).scheduleMinutesFromNow(habit, 15L);
verify(notificationTray).cancel(habit); verify(notificationTray).cancel(habit);
} }

@ -59,12 +59,14 @@ public class ReminderScheduler implements CommandRunner.Listener
public void schedule(@NonNull Habit habit) public void schedule(@NonNull Habit habit)
{ {
if (!habit.hasReminder()) return;
Long reminderTime = habit.getReminder().getTimeInMillis(); Long reminderTime = habit.getReminder().getTimeInMillis();
scheduleAtTime(habit, reminderTime); scheduleAtTime(habit, reminderTime);
} }
public void scheduleAtTime(@NonNull Habit habit, @NonNull Long reminderTime) public void scheduleAtTime(@NonNull Habit habit, @NonNull Long reminderTime)
{ {
if (reminderTime == null) throw new IllegalArgumentException();
if (!habit.hasReminder()) return; if (!habit.hasReminder()) return;
if (habit.isArchived()) return; if (habit.isArchived()) return;
long timestamp = getStartOfDay(removeTimezone(reminderTime)); long timestamp = getStartOfDay(removeTimezone(reminderTime));

@ -118,7 +118,7 @@ public class ReminderSchedulerTest extends BaseUnitTest
@Test @Test
public void testSchedule_withoutReminder() public void testSchedule_withoutReminder()
{ {
reminderScheduler.schedule(habit, null); reminderScheduler.schedule(habit);
Mockito.verifyZeroInteractions(sys); Mockito.verifyZeroInteractions(sys);
} }
@ -133,7 +133,8 @@ public class ReminderSchedulerTest extends BaseUnitTest
long expectedCheckmarkTime, long expectedCheckmarkTime,
long expectedReminderTime) long expectedReminderTime)
{ {
reminderScheduler.schedule(habit, atTime); if(atTime == null) reminderScheduler.schedule(habit);
else reminderScheduler.scheduleAtTime(habit, atTime);
verify(sys).scheduleShowReminder(expectedReminderTime, habit, verify(sys).scheduleShowReminder(expectedReminderTime, habit,
expectedCheckmarkTime); expectedCheckmarkTime);
} }

Loading…
Cancel
Save