From d43fd52553da1738d41303a0e0af48d1d2b948a6 Mon Sep 17 00:00:00 2001 From: powerjungle Date: Sun, 13 Apr 2025 19:21:36 +0200 Subject: [PATCH] fix(ui): hacky fix for updating colors on show question marks setting change This only applies if the grey completed setting is enabled. This is to avoid restarting the app to see the resulting color change, when changing the show question marks setting. It'll be good to call `finish()` on the settings activity, to avoid stacking activities every time the setting is changed. --- .../uhabits/activities/habits/list/ListHabitsActivity.kt | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsActivity.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsActivity.kt index d4e2ffa69..43f9ea09a 100644 --- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsActivity.kt +++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/ListHabitsActivity.kt @@ -75,8 +75,12 @@ class ListHabitsActivity : AppCompatActivity(), Preferences.Listener { private lateinit var menu: ListHabitsMenu override fun onQuestionMarksChanged() { - invalidateOptionsMenu() - menu.behavior.onPreferencesChanged() + if (prefs.greyCompleted) { + restartWithFade(this::class.java) + } else { + invalidateOptionsMenu() + menu.behavior.onPreferencesChanged() + } } override fun onCreate(savedInstanceState: Bundle?) {