From d8894753e0f141418a23ea58d1a901ebe2ba3ab6 Mon Sep 17 00:00:00 2001
From: Christoph Hennemann <christoph.hennemann@gmail.com>
Date: Sun, 20 Jan 2019 00:40:35 +0100
Subject: [PATCH] feat: Add scrollbars to habit overview list

References: #365
---
 .../activities/habits/list/views/HabitCardListView.kt     | 3 ++-
 uhabits-android/src/main/res/layout/about.xml             | 4 ++++
 uhabits-android/src/main/res/values/attrs.xml             | 2 ++
 uhabits-android/src/main/res/values/styles.xml            | 8 ++++++++
 4 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/HabitCardListView.kt b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/HabitCardListView.kt
index c68d56d5a..0989fb660 100644
--- a/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/HabitCardListView.kt
+++ b/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/HabitCardListView.kt
@@ -28,6 +28,7 @@ import android.view.*
 import com.google.auto.factory.*
 import dagger.*
 import org.isoron.androidbase.activities.*
+import org.isoron.uhabits.R
 import org.isoron.uhabits.activities.common.views.*
 import org.isoron.uhabits.core.models.*
 
@@ -37,7 +38,7 @@ class HabitCardListView(
         @Provided private val adapter: HabitCardListAdapter,
         @Provided private val cardViewFactory: HabitCardViewFactory,
         @Provided private val controller: Lazy<HabitCardListController>
-) : RecyclerView(context) {
+) : RecyclerView(context, null, R.attr.scrollableRecyclerViewStyle) {
 
     var checkmarkCount: Int = 0
 
diff --git a/uhabits-android/src/main/res/layout/about.xml b/uhabits-android/src/main/res/layout/about.xml
index f7cd3607d..523c965f6 100644
--- a/uhabits-android/src/main/res/layout/about.xml
+++ b/uhabits-android/src/main/res/layout/about.xml
@@ -132,6 +132,10 @@
                     style="@style/About.Item"
                     android:text="Victor Yu"/>
 
+                <TextView
+                    style="@style/About.Item"
+                    android:text="Christoph Hennemann"/>
+
             </LinearLayout>
 
             <LinearLayout
diff --git a/uhabits-android/src/main/res/values/attrs.xml b/uhabits-android/src/main/res/values/attrs.xml
index 576b65a35..7d645a3ca 100644
--- a/uhabits-android/src/main/res/values/attrs.xml
+++ b/uhabits-android/src/main/res/values/attrs.xml
@@ -54,4 +54,6 @@
     <attr name="cardBackground" format="reference"/>
     <attr name="headerBackground" format="reference"/>
     <attr name="selectedBackground" format="reference"/>
+
+    <attr name="scrollableRecyclerViewStyle" format="reference"/>
 </resources>
\ No newline at end of file
diff --git a/uhabits-android/src/main/res/values/styles.xml b/uhabits-android/src/main/res/values/styles.xml
index bc8bffb2e..bfff08327 100644
--- a/uhabits-android/src/main/res/values/styles.xml
+++ b/uhabits-android/src/main/res/values/styles.xml
@@ -65,6 +65,8 @@
         <item name="aboutScreenColor">@color/blue_800</item>
         <item name="widgetShadowAlpha">0.25</item>
         <item name="widgetBackgroundAlpha">1</item>
+
+        <item name="scrollableRecyclerViewStyle">@style/ScrollableRecyclerViewStyle</item>
     </style>
 
     <style name="SmallSpinner">
@@ -120,6 +122,8 @@
 
         <item name="widgetShadowAlpha">0.25</item>
         <item name="widgetBackgroundAlpha">1</item>
+
+        <item name="scrollableRecyclerViewStyle">@style/ScrollableRecyclerViewStyle</item>
     </style>
 
     <style name="AppBaseThemeDark.PureBlack">
@@ -254,4 +258,8 @@
            parent="@style/Theme.AppCompat.Dialog">
         <item name="windowNoTitle">false</item>
     </style>
+
+    <style name="ScrollableRecyclerViewStyle" parent="android:Widget">
+        <item name="android:scrollbars">vertical</item>
+    </style>
 </resources>