From f3b9fc825a8878bf1377cf3f044eeb106b8826fe Mon Sep 17 00:00:00 2001 From: Alinson Xavier Date: Sun, 9 Oct 2016 11:58:03 -0400 Subject: [PATCH] HabitMatcher: only compute today's value if needed --- .../main/java/org/isoron/uhabits/models/HabitMatcher.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/isoron/uhabits/models/HabitMatcher.java b/app/src/main/java/org/isoron/uhabits/models/HabitMatcher.java index dadff87ae..afc8d6ff7 100644 --- a/app/src/main/java/org/isoron/uhabits/models/HabitMatcher.java +++ b/app/src/main/java/org/isoron/uhabits/models/HabitMatcher.java @@ -76,8 +76,12 @@ public class HabitMatcher if (!isArchivedAllowed() && habit.isArchived()) return false; if (isReminderRequired() && !habit.hasReminder()) return false; - int todayCheckmark = habit.getCheckmarks().getTodayValue(); - if (todayCheckmark != UNCHECKED && !isCompletedAllowed()) return false; + if(!isCompletedAllowed()) + { + int todayCheckmark = habit.getCheckmarks().getTodayValue(); + if (todayCheckmark != UNCHECKED) return false; + } + if(!allowedColors.contains(habit.getColor())) return false; return true; }