diff --git a/android/uhabits-android/build.gradle b/android/uhabits-android/build.gradle index 521f4f19a..39affba4e 100644 --- a/android/uhabits-android/build.gradle +++ b/android/uhabits-android/build.gradle @@ -87,6 +87,7 @@ dependencies { implementation "com.google.code.gson:gson:2.8.5" implementation "com.google.code.findbugs:jsr305:3.0.2" implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$KOTLIN_VERSION" + implementation "androidx.constraintlayout:constraintlayout:2.0.0-beta4" compileOnly "javax.annotation:jsr250-api:1.0" compileOnly "com.google.auto.factory:auto-factory:$AUTO_FACTORY_VERSION" diff --git a/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/CommonSteps.java b/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/CommonSteps.java index 967a6b70d..216e6e075 100644 --- a/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/CommonSteps.java +++ b/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/CommonSteps.java @@ -23,7 +23,6 @@ import androidx.annotation.StringRes; import androidx.test.espresso.*; import androidx.test.espresso.contrib.*; import androidx.test.uiautomator.*; -import androidx.appcompat.widget.*; import androidx.recyclerview.widget.RecyclerView; @@ -167,7 +166,7 @@ public class CommonSteps extends BaseUserInterfaceTest break; case EDIT_HABIT: - onView(withId(R.id.tvDescription)).check(matches(isDisplayed())); + onView(withId(R.id.tvQuestion)).check(matches(isDisplayed())); break; } } diff --git a/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/EditHabitSteps.java b/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/EditHabitSteps.java index 90293cc24..90d0596b7 100644 --- a/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/EditHabitSteps.java +++ b/android/uhabits-android/src/androidTest/java/org/isoron/uhabits/acceptance/steps/EditHabitSteps.java @@ -55,7 +55,7 @@ public class EditHabitSteps public static void typeQuestion(String name) { - typeTextWithId(R.id.tvDescription, name); + typeTextWithId(R.id.tvQuestion, name); } public static void setReminder() diff --git a/android/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/edit/views/NameDescriptionPanel.java b/android/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/edit/views/NameDescriptionPanel.java index 5eb73a5e1..ca30a631c 100644 --- a/android/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/edit/views/NameDescriptionPanel.java +++ b/android/uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/edit/views/NameDescriptionPanel.java @@ -42,6 +42,9 @@ public class NameDescriptionPanel extends FrameLayout @BindView(R.id.tvName) EditText tvName; + @BindView(R.id.tvQuestion) + ExampleEditText tvQuestion; + @BindView(R.id.tvDescription) ExampleEditText tvDescription; @@ -76,7 +79,7 @@ public class NameDescriptionPanel extends FrameLayout @NonNull public String getDescription() { - return tvDescription.getRealText().trim(); + return tvQuestion.getRealText().trim(); } @NonNull @@ -90,13 +93,13 @@ public class NameDescriptionPanel extends FrameLayout Resources res = getResources(); if(habit.isNumerical()) - tvDescription.setExample(res.getString(R.string.example_question_numerical)); + tvQuestion.setExample(res.getString(R.string.example_question_numerical)); else - tvDescription.setExample(res.getString(R.string.example_question_boolean)); + tvQuestion.setExample(res.getString(R.string.example_question_boolean)); setColor(habit.getColor()); tvName.setText(habit.getName()); - tvDescription.setRealText(habit.getDescription()); + tvQuestion.setRealText(habit.getDescription()); } public boolean validate() diff --git a/android/uhabits-android/src/main/java/org/isoron/uhabits/notifications/AndroidNotificationTray.kt b/android/uhabits-android/src/main/java/org/isoron/uhabits/notifications/AndroidNotificationTray.kt index 2b9036993..76a6132a5 100644 --- a/android/uhabits-android/src/main/java/org/isoron/uhabits/notifications/AndroidNotificationTray.kt +++ b/android/uhabits-android/src/main/java/org/isoron/uhabits/notifications/AndroidNotificationTray.kt @@ -115,7 +115,7 @@ class AndroidNotificationTray val builder = NotificationCompat.Builder(context, REMINDERS_CHANNEL_ID) .setSmallIcon(R.drawable.ic_notification) .setContentTitle(habit.name) - .setContentText(if(habit.description.isBlank()) defaultText else habit.description) + .setContentText(if(habit.description.isNullOrBlank()) defaultText else habit.description) .setContentIntent(pendingIntents.showHabit(habit)) .setDeleteIntent(pendingIntents.dismissNotification(habit)) .addAction(addRepetitionAction) diff --git a/android/uhabits-android/src/main/res/layout/edit_habit_name.xml b/android/uhabits-android/src/main/res/layout/edit_habit_name.xml index 70a8137b7..cb0c660cf 100644 --- a/android/uhabits-android/src/main/res/layout/edit_habit_name.xml +++ b/android/uhabits-android/src/main/res/layout/edit_habit_name.xml @@ -1,5 +1,4 @@ - - - + android:layout_height="wrap_content" + android:minWidth="300dp"> - + - + android:ellipsize="start" + android:gravity="center_vertical" + android:hint="@string/name"> - + + + - - - + - + - + + + android:layout_width="0dp" + android:layout_height="wrap_content" + android:layout_marginTop="8dp" + android:hint="@string/notes" + app1:layout_constraintBottom_toBottomOf="parent" + app1:layout_constraintEnd_toEndOf="parent" + app1:layout_constraintStart_toStartOf="parent" + app1:layout_constraintTop_toBottomOf="@id/tilQuestion"> + android:layout_height="match_parent" + android:gravity="top" + android:minHeight="300dp" + app:example="@string/example_notes" /> - \ No newline at end of file + \ No newline at end of file diff --git a/android/uhabits-android/src/main/res/values/strings.xml b/android/uhabits-android/src/main/res/values/strings.xml index af088952a..d2273b13b 100644 --- a/android/uhabits-android/src/main/res/values/strings.xml +++ b/android/uhabits-android/src/main/res/values/strings.xml @@ -244,5 +244,7 @@ Makes widgets more transparent or more opaque in your home screen. First day of the week Have you completed this habit today? + Notes + You can put whatever you want here! \ No newline at end of file