Place the noBtn button on the left and the yesBtn button on the right. This aligns with the common reading pattern (left to right) and helps users quickly identify the action they want to take.

pull/2198/head
Helskog 2 months ago
parent 35274b7c85
commit 3f6278e124

@ -25,6 +25,7 @@ import android.view.LayoutInflater
import android.view.View.GONE import android.view.View.GONE
import android.view.View.VISIBLE import android.view.View.VISIBLE
import androidx.appcompat.app.AppCompatDialogFragment import androidx.appcompat.app.AppCompatDialogFragment
import androidx.preference.PreferenceManager
import org.isoron.uhabits.HabitsApplication import org.isoron.uhabits.HabitsApplication
import org.isoron.uhabits.R import org.isoron.uhabits.R
import org.isoron.uhabits.core.models.Entry.Companion.NO import org.isoron.uhabits.core.models.Entry.Companion.NO
@ -53,8 +54,12 @@ class CheckmarkDialog : AppCompatDialogFragment() {
it.typeface = getFontAwesome(requireContext()) it.typeface = getFontAwesome(requireContext())
} }
view.notes.setText(requireArguments().getString("notes")!!) view.notes.setText(requireArguments().getString("notes")!!)
if (!prefs.isSkipEnabled) view.skipBtn.visibility = GONE if (!prefs.isSkipEnabled)
if (!prefs.areQuestionMarksEnabled) view.unknownBtn.visibility = GONE view.skipBtn.visibility = GONE
if (!prefs.areQuestionMarksEnabled)
view.unknownBtn.visibility = GONE
view.booleanButtons.visibility = VISIBLE view.booleanButtons.visibility = VISIBLE
val dialog = Dialog(requireContext()) val dialog = Dialog(requireContext())
dialog.setContentView(view.root) dialog.setContentView(view.root)

@ -53,9 +53,9 @@
app:showDividers="middle"> app:showDividers="middle">
<TextView <TextView
android:id="@+id/yesBtn" android:id="@+id/noBtn"
style="@style/CheckmarkPopupBtn" style="@style/CheckmarkPopupBtn"
android:text="@string/fa_check" /> android:text="@string/fa_times" />
<TextView <TextView
android:id="@+id/skipBtn" android:id="@+id/skipBtn"
@ -63,9 +63,9 @@
android:text="@string/fa_skipped" /> android:text="@string/fa_skipped" />
<TextView <TextView
android:id="@+id/noBtn" android:id="@+id/yesBtn"
style="@style/CheckmarkPopupBtn" style="@style/CheckmarkPopupBtn"
android:text="@string/fa_times" /> android:text="@string/fa_check" />
<TextView <TextView
android:id="@+id/unknownBtn" android:id="@+id/unknownBtn"

Loading…
Cancel
Save