isoron/loop
1
1
Fork 0
mirror of https://github.com/iSoron/uhabits.git synced 2025-12-06 09:08:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

fixing some comments from @hiqua

Browse Source
This commit is contained in:
Gokul K
2023-07-04 18:50:28 +05:30
committed by Alinson S. Xavier
parent 08410c59d0
commit ad8738180c
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
uhabits-android/src/main/java/org/isoron/uhabits/activities/common/dialogs/NumberDialog.kt
View File

@@ -117,11 +117,11 @@ class NumberDialog : AppCompatDialogFragment() {
val notes = view.notes.text.toString() val notes = view.notes.text.toString()
onToggle(value, notes) onToggle(value, notes)
requireDialog().dismiss() requireDialog().dismiss()
val v = requireActivity().findViewById<LinearLayout>(R.id.konfettiLayout) val konfettiView = requireActivity().findViewById<LinearLayout>(R.id.konfettiLayout)
if (value > 0.0) { if (value > 0.0) {
showConfetti(v) //To motivate, show confetti even if some value is present
showConfetti(konfettiView)
} }
} }
} }

4
uhabits-android/src/main/java/org/isoron/uhabits/activities/habits/list/views/CheckmarkButtonView.kt
View File

@@ -89,7 +89,7 @@ class CheckmarkButtonView(
setOnLongClickListener(this) setOnLongClickListener(this)
} }
fun performToggle(v: View) { fun performToggle(view: View) {
value = Entry.nextToggleValue( value = Entry.nextToggleValue(
value = value, value = value,
isSkipEnabled = preferences.isSkipEnabled, isSkipEnabled = preferences.isSkipEnabled,
@@ -98,7 +98,7 @@ class CheckmarkButtonView(
onToggle(value, notes) onToggle(value, notes)
performHapticFeedback(HapticFeedbackConstants.LONG_PRESS) performHapticFeedback(HapticFeedbackConstants.LONG_PRESS)
when (value) { when (value) {
YES_MANUAL -> showConfetti(v.rootView) YES_MANUAL -> showConfetti(view.rootView)
} }
invalidate() invalidate()
} }